Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityGenerator produces class with 2 empty lines at the end of the file #6164

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

eyepin
Copy link
Contributor

@eyepin eyepin commented Dec 7, 2016

orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.

this worked for me

orm:generate:entities genrates 2 blank lines
PSR2: All PHP files MUST end with a single blank line.

this worked for me
@RepmujNetsik
Copy link

RepmujNetsik commented Dec 11, 2016

first blank line because:

protected static $classTemplate =
'<?php

<namespace>
<useStatement>
<entityAnnotation>
<entityClassName>
{
<entityBody>
}
';

second because method generateEntityClass()

@Ocramius
Copy link
Member

Not requiring a test for this one, since the EntityGenerator is far from critical, but please do submit PRs with tests next time.

@Ocramius Ocramius added this to the 2.6.0 milestone Dec 12, 2016
@Ocramius Ocramius self-assigned this Dec 12, 2016
@Ocramius Ocramius merged commit 6e6be3f into doctrine:master Dec 12, 2016
@Ocramius Ocramius changed the title Update EntityGenerator.php EntityGenerator produces class with 2 empty lines at the end of the file Dec 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants