Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Be strict with risky tests #6607

Merged
merged 2 commits into from
Aug 6, 2017
Merged

Be strict with risky tests #6607

merged 2 commits into from
Aug 6, 2017

Commits on Aug 6, 2017

  1. Make PHPUnit strict about risky tests

    @lcobucci
    lcobucci committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    27300bf View commit details
    Browse the repository at this point in the history

  2. Move test to the right place and add assertions 

    That test was removed from "performance" group but we forgot to move it
to the correct namespace.

It was also not doing any assertion, which is quite bad.

More info:
- doctrine#3333
    @lcobucci
    lcobucci committed Aug 6, 2017
    Configuration menu
    Copy the full SHA
    b960170 View commit details
    Browse the repository at this point in the history