-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed issue #2633 #9606
base: 2.11.x
Are you sure you want to change the base?
Fixed issue #2633 #9606
Conversation
Items in $rowData['data'] in ArrayHydrator is now sorted by level obtained from ResultSetMapping::$parentAliasMap
7f01215
to
9730cfb
Compare
Co-authored-by: Alexander M. Turek <me@derrabus.de>
All this code is executed on processing every row over and over again. This needs a performance evaluation. Is it possible to move some or all of this logic into the prepare state? |
To summarize It requires two foreach, sorting and merging. Effectively adding 4O(N) to the inside of an existing loop, thats my concern |
I understand your concerns... I'm not sure about moving to the prepared state. It is worth mentioning that hydrating into objects works just fine, any idea how is that possible? |
Hi, |
There hasn't been any activity on this pull request in the past 90 days, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 7 days. |
Fixes issue #2633
Items in $rowData['data'] in ArrayHydrator is now sorted by level obtained from ResultSetMapping::$parentAliasMap
ArrayHydrator now considers the set mapping to correctly provide data.