fix: Normalize class names #300

[Tofandel]

Fixes #300

[greg0ire]

If you are having static analysis issues, consider cloning this for Psalm: phpstan/phpstan#7483

[greg0ire]

Note for maintainers or @Tofandel : I think the commits can be squashed.

[greg0ire]

Thanks @Tofandel !

[writ3it]

Hi,

this PR breaks test ClassMetadataFactoryTest::testHasGetMetadataNamespaceSeparatorIsNotNormalized in doctrine/orm:2.12.x.

You can check test results here: https://github.com/doctrine/orm/runs/7698594303?check_suite_focus=true.
Test was implemented here: doctrine/orm@884131e to solve issue described here: doctrine/orm#1750.

@Tofandel could you check this case? What we can do?

[Tofandel]

The threads are very hard to follow, but to me it seems, as per the last comment, that the linked issue had nothing to do with class normalization, and was related to namespace and a different fix was applied, so it's safe to modify this test to isSame and isTrue instead of isNotSame and isFalse, because the test mentionned was a revert and does nothing to check the issue (unless I didn't understand it in the first place), and only checks for the opposite of what is expected, since \DoctrineGlobal_Article is in fact the same class as DoctrineGlobal_Article, which is an issue

You can even see that the real tests for the issues are marked as

    /**
     * @group DDC-115
     */

But this specific test is not

And that this test was first created in doctrine/orm@120e694
And then the next commit just modify this test to check for the exact opposite, which is not the desired behavior, but at the time it was for "performance concerns"

Given that compared to php 5, php 8 is ~120% faster and that doctrine has a lot more caching now and that this really is such a fast triming operation, it's not a valid argument anymore

[writ3it]

Thank you a lot for the explanation and improvement!