add tests to cover error cases for dsUtils.makeRequest

Author: Whoaa512

dsUtils.js

@@ -112,7 +112,6 @@ exports.makeRequest = function (apiName, options, callback) {
     exports.log(util.format('DS API %s Request:\n  %s %s\t  %s\nHeaders: %s', apiName, options.method, options.url, util.inspect(data, {depth: null}), util.inspect(options.headers, {depth: null})));
 
     request(options, function (error, response, body) {
-      /* istanbul ignore if */
       if (error) {
         return reject(error);
       }
@@ -145,9 +144,7 @@ exports.makeRequest = function (apiName, options, callback) {
     });
   });
   return makeRequestAsync.asCallback(callback).catch(DocuSignError, function (error) {
-    /* istanbul ignore next */
     exports.log(error.message);
-    /* istanbul ignore next */
     throw error;
   });
 };

package.json

@@ -69,6 +69,7 @@
     "proxyquire": "1.7.3",
     "require-uncached": "1.0.2",
     "semistandard": "7.0.2",
+    "sinon": "1.17.1",
     "write-json-file": "1.1.1"
   },
   "pre-commit": [

test/dsUtils.spec.js

@@ -0,0 +1,53 @@
+'use strict';
+
+const test = require('ava');
+const proxyquire = require('proxyquire');
+const sinon = require('sinon');
+
+let dsUtils;
+
+test('[makeRequest] error', t => {
+  let error = new Error('broken');
+  dsUtils = proxyquire('../dsUtils', {
+    request: sinon.stub().callsArgWith(1, error)
+  });
+  return dsUtils.makeRequest('broken', {})
+  .catch(err => {
+    t.ok(err);
+    t.same(err, error);
+  });
+});
+
+test('[makeRequest] errorCode in body', t => {
+  let error = null;
+  let body = {
+    errorCode: 'Something broke',
+    message: 'Who knows why'
+  };
+  let resp = { body };
+  dsUtils = proxyquire('../dsUtils', {
+    request: sinon.stub().callsArgWith(1, error, resp, body)
+  });
+  return dsUtils.makeRequest('broken', {})
+  .catch(err => {
+    t.ok(err);
+    t.ok(err.name === 'DocuSignError');
+  });
+});
+
+test('[makeRequest] error in body', t => {
+  let error = null;
+  let body = {
+    error: 'Something broke',
+    error_description: 'Who knows why'
+  };
+  let resp = { body };
+  dsUtils = proxyquire('../dsUtils', {
+    request: sinon.stub().callsArgWith(1, error, resp, body)
+  });
+  return dsUtils.makeRequest('broken', {})
+  .catch(err => {
+    t.ok(err);
+    t.ok(err.name === 'DocuSignError');
+  });
+});