Skip to content

Commit 97c1b5b

Browse files
committed
refactor getSignedDocuments to use dsUtils.makeRequest
1 parent c746bfb commit 97c1b5b

File tree

1 file changed

+7
-34
lines changed

1 file changed

+7
-34
lines changed

components/envelopes.js

Lines changed: 7 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -693,41 +693,14 @@ function setEnvelopeStatus (apiToken, baseUrl, envelopeId, status, additionalPar
693693
* @returns {Promise} - A thenable bluebird Promise fulfilled with the PDF file buffer in the given `encoding`.
694694
*/
695695
function getSignedDocuments (apiToken, baseUrl, envelopeId, encoding, attachCertificate) {
696-
return new Bluebird(function (resolve, reject) {
697-
var options = {
698-
method: 'GET',
699-
url: baseUrl + '/envelopes/' + envelopeId + '/documents/combined?certificate=' + attachCertificate,
700-
headers: dsUtils.getHeaders(apiToken),
701-
encoding: encoding
702-
};
696+
var options = {
697+
method: 'GET',
698+
url: baseUrl + '/envelopes/' + envelopeId + '/documents/combined?certificate=' + attachCertificate,
699+
headers: dsUtils.getHeaders(apiToken),
700+
encoding: encoding
701+
};
703702

704-
// @todo: fix this to use makeRequest
705-
request(options, function (error, response, body) {
706-
if (error) {
707-
return reject(error);
708-
}
709-
if (response.statusCode !== 200 && response.statusCode !== 201) {
710-
var parsedBody, message, errorCode;
711-
try {
712-
parsedBody = JSON.parse(body.toString());
713-
message = parsedBody.message;
714-
errorCode = parsedBody.errorCode;
715-
} catch (e) {
716-
message = body.toString();
717-
errorCode = null;
718-
}
719-
return reject(new DocuSignError(response.statusCode + ': ' + message, {
720-
statusCode: response.statusCode,
721-
errorCode: errorCode
722-
}));
723-
}
724-
resolve(body);
725-
});
726-
})
727-
.catch(DocuSignError, function (error) {
728-
dsUtils.log('DS API Get Signed Documents Error:\n %s', error.message);
729-
throw error;
730-
});
703+
return dsUtils.makeRequest('Get Signed Documents', options);
731704
}
732705

733706
/**

0 commit comments

Comments
 (0)