Always use svg series icon #5214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorg-vr
requested review from
bmesuere and
chvp
and removed request for
a team
jorg-vr
changed the title
chvp
approved these changes
Dec 5, 2023
bmesuere
requested changes
Dec 19, 2023
Comment on lines
+10
to
+13
| * @cssprop --icon-color - the color of the icon | ||
| * @cssprop --icon-background-color - the background color of the icon | ||
| * @cssprop --deadline-icon-color - the color of the deadline icon | ||
| * @cssprop --deadline-icon-background-color - the background color of the deadline icon |
There was a problem hiding this comment.
Are these specified in a general css file? Why not add them here to make this component self contained?
There was a problem hiding this comment.
Right now it is a shadowless lit component, which forces all style definitions to be in the global scope.
Changing it to use the shadow dom would not allow any use of globally defined classes. In this this would mean we had to redefine the material design icons used within this class. I do not think that is desired.
Sadly there is no way to 'partially' use the shadow dom. Which is why we also aren't using the shadow dom in most other components for now.
bmesuere
approved these changes
Jan 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes #5213
It were actually to separate bugs:
The fix removes the simplified icon, always using the svg version.
The amount of html remains limited for non loaded series because the svg code is moved to a web component.
Closes #5213