Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend allowed tags and attributes (svg) #5301

Merged
merged 1 commit into from
Jan 17, 2024
Merged

Extend allowed tags and attributes (svg) #5301

merged 1 commit into from
Jan 17, 2024

Conversation

tibvdm
Copy link
Collaborator

@tibvdm tibvdm commented Jan 16, 2024

This pull request adds additional SVG tags:
<defs> <use>

And attributes:
color

  • Tests were added
  • Documentation update can be found at dodona-edu/dodona-edu.github.io#

@tibvdm tibvdm requested a review from a team as a code owner January 16, 2024 23:04
@tibvdm tibvdm requested review from jorg-vr and chvp and removed request for a team January 16, 2024 23:04
@bmesuere
Copy link
Member

Is this really needed? There is a reason we filter svg's and use is one of the tricky elements which can be exploited.

@pdawyndt
Copy link
Contributor

@bmesuere We have an assignment in today's exam, where the goal is to generate an SVG that makes use of the use-tag. The SVG contains repeated patterns, and the use-tag is used to keep the generated output as small as possible. When the output grows too large, Dodona no longer diffs the output and it becomes really hard to see for the students where some (possible small) differences are located.

@bmesuere
Copy link
Member

I that case is propose to allow it for now, but disable it again after grading is done.

@jorg-vr jorg-vr merged commit 3f538f9 into main Jan 17, 2024
13 checks passed
@jorg-vr jorg-vr deleted the svg-attributes branch January 17, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants