Fix comment of seed PR #2
Conversation
Man command do not work properly on ubuntu minimized image, fix it using python regex directly on man file
Fix last comment of dogecoin/dogecoin#2337
|
Error on pushed commits |
| @@ -1,4 +1,4 @@ | |||
| FROM ubuntu:bionic | |||
| FROM ubuntu:focal | |||
There was a problem hiding this comment.
Need to either rename the folder to x86_64-focal or keep this bionic for now. I'd recommend the latter, then we just create a focal (or maybe better, because smaller AND newer: debian:bullseye) image for 1.14.5.
There was a problem hiding this comment.
I didn't read carefully the folder name, I missed the version.
I would say we shouldn't have subfolder for distro version nor plateform. Virtualization should deal with it. I've to try the behavior on a raspberry if a non-arm executable will work inside the container.
Take a look at mysql Dockerfile, it's by version and not by platform, they are only using debian:buster-slim to provide image for versions 5.6, 5.7 & 8.0.
There was a problem hiding this comment.
Possibly the repository architecture will be a single Dockerfile by version. And it would be definitively easier to maintain.
There was a problem hiding this comment.
I would say we shouldn't have subfolder for distro version nor plateform.
Where would I put the Dockerfiles for alpine 3.13 and 3.14 images? Dogecoin Core got patched for musl compatibility and we can support it...
Virtualization should deal with it
We have multi-platform binaries, but you're saying is it's better to run x86 binaries on ARM through emulation?
they are only using
debian:buster-slim
I don't think we should exclude for example Alpine users just because that's a design choice that was made for mysql. Other official packages made different choices, eg: postgres, redis, extreme example: nodejs, and so on.
Even if we were to choose to just support 1 distro (eg: debian) then there's still the issue that the Dogecoin Core release cycles are not at all in sync with distro release cycles. Since the goal must be to make production images (otherwise we may as well just keep all this in user repos and not care) we will have to think a bit about upgrade policies. You don't want to force updates cross distro release but instead enable custom security policies, the former will just lead to no one using the images we are proposing here at some point. I think that we'll have to maintain, say, dogecoin:1.14.6-bullseye-slim and dogecoin:1.14.6-bookworm-slim concurrently in the most minimal of supported cases.
Fix last comment from PR dogecoin/dogecoin#2337 about base image + workdir variable