Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps/apt-get #42

Merged
merged 1 commit into from
Dec 15, 2021
Merged

deps/apt-get #42

merged 1 commit into from
Dec 15, 2021

Conversation

xanimo
Copy link
Member

@xanimo xanimo commented Dec 12, 2021

fix DL3027

AbcSxyZ
AbcSxyZ previously approved these changes Dec 12, 2021
View reviewed changes
Copy link
Contributor

@AbcSxyZ AbcSxyZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. We can add hadolint linter too, I will recommend it in #37.

@patricklodder patricklodder mentioned this pull request Dec 12, 2021
Merged
@patricklodder
Copy link
Member

Needs rebase

@patricklodder patricklodder added this to 🚀 Everything else in Review board Dec 12, 2021
This was referenced Dec 12, 2021
Open
Merged
@patricklodder patricklodder added the bug Something isn't working label Dec 12, 2021
@xanimo
deps/apt-get
2af895d 
fix DL3027
@xanimo
Copy link
Member Author

xanimo commented Dec 12, 2021

Needs rebase

done

patricklodder
patricklodder approved these changes Dec 12, 2021
View reviewed changes
Copy link
Member

@patricklodder patricklodder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested ACK. Thanks!

@patricklodder patricklodder merged commit 4d5b695 into dogecoin:main Dec 15, 2021
@patricklodder patricklodder removed this from 🚀 Everything else in Review board Dec 15, 2021
@xanimo xanimo mentioned this pull request Dec 16, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patricklodder patricklodder patricklodder approved these changes

@AbcSxyZ AbcSxyZ AbcSxyZ left review comments

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xanimo @patricklodder @AbcSxyZ