Support handlers that are disabled by their configuration. #339
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What change does this introduce?
This PR changes the
engine
package to skip any disabled handlers by default.Why make this change?
Further prototyping of the disabling feature before committing to add it to the dogma interfaces.
Is there anything you are unsure about?
testkit
already has its own concept of enabling/disabling handlers. I've opted to disallow explicitly enabling a handler that has been disable inConfigure()
via theTest
interface, but this is allowed via the lower-level interface of theengine
package.I am not sure what behavior
EnableHandlersLike(pattern)
should have if it matches a handler that has been explicitly disabled by its configuration. The options are:panicenable the handler anyway (not really a valid option, as it would almost certainly result in some other unexpected behavior)Ultimately, I'd like to work towards removing the need to enable/disable individual handlers in tests, but I'm not sure that's really feasible.
What issues does this relate to?