Add NewPersonView unit tests

SWDestinyTrades/Classes/NewPerson/Controller/NewPersonViewController.swift

@@ -10,13 +10,13 @@ import UIKit
 
 final class NewPersonViewController: UIViewController {
 
-    private let newPersonView: NewPersonView
+    private let newPersonView: NewPersonViewType
 
     var presenter: NewPersonPresenterProtocol?
 
     // MARK: - Life Cycle
 
-    init(with view: NewPersonView = NewPersonView()) {
+    init(with view: NewPersonViewType) {
         newPersonView = view
         super.init(nibName: nil, bundle: nil)
     }
@@ -52,9 +52,7 @@ extension NewPersonViewController: NewPersonViewControllerProtocol {
     }
 
     func retriveUserInput() -> (name: String, lastName: String) {
-        let name = newPersonView.firstNameTextField.nonOptionalText
-        let lastName = newPersonView.lastNameTextField.nonOptionalText
-        return (name, lastName)
+        return newPersonView.retriveUserInput()
     }
 
     func closeViewController() {

SWDestinyTrades/Classes/NewPerson/View/NewPersonView.swift

@@ -8,20 +8,19 @@
 
 import UIKit
 
-final class NewPersonView: UIView {
+final class NewPersonView: UIView, NewPersonViewType {
 
-    lazy var firstNameTextField: FloatingTextfield = {
+    private let firstNameTextField: FloatingTextfield = {
         let textField = FloatingTextfield(frame: .zero)
         textField.textColor = .whiteBlack
         textField.autocapitalizationType = .sentences
         textField.font = UIFont.systemFont(ofSize: 17)
         textField.placeholder = L10n.firstName
         textField.placeholderTextColor = .secondaryLabel
-        textField.delegate = self
         return textField
     }()
 
-    var lastNameTextField: FloatingTextfield = {
+    private let lastNameTextField: FloatingTextfield = {
         let textField = FloatingTextfield(frame: .zero)
         textField.textColor = .whiteBlack
         textField.autocapitalizationType = .sentences
@@ -40,6 +39,12 @@ final class NewPersonView: UIView {
     required init?(coder aDecoder: NSCoder) {
         fatalError("init(coder:) has not been implemented")
     }
+
+    func retriveUserInput() -> (name: String, lastName: String) {
+        let name = firstNameTextField.nonOptionalText
+        let lastName = lastNameTextField.nonOptionalText
+        return (name, lastName)
+    }
 }
 
 extension NewPersonView: BaseViewConfiguration {
@@ -67,6 +72,7 @@ extension NewPersonView: BaseViewConfiguration {
 
     func configureViews() {
         backgroundColor = .blackWhite
+        firstNameTextField.delegate = self
     }
 }
 

SWDestinyTrades/Classes/NewPerson/View/NewPersonViewType.swift

@@ -0,0 +1,15 @@
+//
+//  NewPersonViewType.swift
+//  SWDestinyTrades
+//
+//  Created by Diogo Autilio on 29/02/24.
+//  Copyright © 2024 Diogo Autilio. All rights reserved.
+//
+
+import Foundation
+import UIKit
+
+protocol NewPersonViewType where Self: UIView {
+
+    func retriveUserInput() -> (name: String, lastName: String)
+}

SWDestinyTrades/Classes/PeopleList/Navigator/PeopleListNavigator.swift

@@ -36,7 +36,7 @@ final class PeopleListNavigator: Navigator {
         case let .loanDetail(database, person):
             return LoansDetailViewControllerFactory(database: database, person: person).createViewController()
         case let .newPerson(delegate):
-            let viewController = NewPersonViewController()
+            let viewController = NewPersonViewController(with: NewPersonView())
             let presenter = NewPersonPresenter(controller: viewController, delegate: delegate)
             viewController.presenter = presenter
             return viewController

SWDestinyTradesTests/Screens/NewPerson/Controller/NewPersonViewControllerTests.swift

@@ -15,21 +15,24 @@ final class NewPersonViewControllerTests: XCTestCase {
 
     private var sut: NewPersonViewController!
     private var presenter: NewPersonPresenterSpy!
+    private var view: NewPersonViewSpy!
     private var navigationController: UINavigationControllerMock!
     private var keyWindow: UIWindow!
 
     override func setUp() {
         super.setUp()
         keyWindow = UIWindow(frame: .testDevice)
         presenter = NewPersonPresenterSpy()
-        sut = NewPersonViewController()
+        view = NewPersonViewSpy()
+        sut = NewPersonViewController(with: view)
         sut.presenter = presenter
         navigationController = UINavigationControllerMock(rootViewController: sut)
         keyWindow.showTestWindow(controller: navigationController)
     }
 
     override func tearDown() {
         navigationController = nil
+        view = nil
         sut = nil
         keyWindow.cleanTestWindow()
         super.tearDown()
@@ -38,7 +41,7 @@ final class NewPersonViewControllerTests: XCTestCase {
     func test_loadView() {
         sut.loadView()
 
-        XCTAssertTrue(sut.view is NewPersonView)
+        XCTAssertTrue(sut.view is NewPersonViewType)
     }
 
     func test_viewDidLoad() {
@@ -60,10 +63,12 @@ final class NewPersonViewControllerTests: XCTestCase {
     }
 
     func test_retriveUserInput() {
+        view.userInput = ("Darth", "Vader")
+
         let userInput = sut.retriveUserInput()
 
-        XCTAssertEqual(userInput.name, "")
-        XCTAssertEqual(userInput.lastName, "")
+        XCTAssertEqual(userInput.name, "Darth")
+        XCTAssertEqual(userInput.lastName, "Vader")
     }
 
     func test_closeViewController() {

SWDestinyTradesTests/Screens/NewPerson/Doubles/NewPersonViewSpy.swift

@@ -0,0 +1,22 @@
+//
+//  NewPersonViewSpy.swift
+//  SWDestinyTradesTests
+//
+//  Created by Diogo Autilio on 29/02/24.
+//  Copyright © 2024 Diogo Autilio. All rights reserved.
+//
+
+import Foundation
+import UIKit
+
+@testable import SWDestinyTrades
+
+final class NewPersonViewSpy: UIView, NewPersonViewType {
+
+    private(set) var didCallRetriveUserInputCount = 0
+    var userInput: (name: String, lastName: String) = ("", "")
+    func retriveUserInput() -> (name: String, lastName: String) {
+        didCallRetriveUserInputCount += 1
+        return userInput
+    }
+}

SWDestinyTradesTests/Screens/NewPerson/Mirror/NewPersonView+Mirror.swift

@@ -0,0 +1,23 @@
+//
+//  NewPersonView+Mirror.swift
+//  SWDestinyTradesTests
+//
+//  Created by Diogo Autilio on 29/02/24.
+//  Copyright © 2024 Diogo Autilio. All rights reserved.
+//
+
+import Foundation
+import UIKit
+
+@testable import SWDestinyTrades
+
+extension NewPersonView {
+
+    var firstNameTextField: FloatingTextfield {
+        Mirror.extract(variable: "firstNameTextField", from: self)!
+    }
+
+    var lastNameTextField: FloatingTextfield {
+        Mirror.extract(variable: "lastNameTextField", from: self)!
+    }
+}

SWDestinyTradesTests/Screens/NewPerson/View/NewPersonViewTests.swift

@@ -0,0 +1,52 @@
+//
+//  NewPersonViewTests.swift
+//  SWDestinyTradesTests
+//
+//  Created by Diogo Autilio on 29/02/24.
+//  Copyright © 2024 Diogo Autilio. All rights reserved.
+//
+
+import UIKit
+import XCTest
+
+@testable import SWDestinyTrades
+
+final class NewPersonViewTests: XCTestCase {
+
+    private var sut: NewPersonView!
+
+    override func setUp() {
+        super.setUp()
+        sut = NewPersonView(frame: .testDevice)
+    }
+
+    override func tearDown() {
+        sut = nil
+        super.tearDown()
+    }
+
+    func test_retriveUserInput() {
+        sut.firstNameTextField.text = "Darth"
+        sut.lastNameTextField.text = "Vader"
+
+        let userInput = sut.retriveUserInput()
+
+        XCTAssertEqual(userInput.name, "Darth")
+        XCTAssertEqual(userInput.lastName, "Vader")
+    }
+
+    func test_textFieldShouldReturn() {
+        // isFirstResponder needs a UIWindow to work properly
+        let controller = UIViewController()
+        let keyWindow = UIWindow(frame: .testDevice)
+        controller.view = sut
+        keyWindow.showTestWindow(controller: controller)
+
+        XCTAssertFalse(sut.lastNameTextField.isFirstResponder)
+
+        let result = sut.textFieldShouldReturn(sut.firstNameTextField)
+
+        XCTAssertTrue(sut.lastNameTextField.isFirstResponder)
+        XCTAssertTrue(result)
+    }
+}