Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "table" to "type" #17

Closed
simonw opened this issue Sep 6, 2020 · 2 comments
Closed

Rename "table" to "type" #17

simonw opened this issue Sep 6, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@simonw
Copy link
Collaborator

simonw commented Sep 6, 2020

I think "table" is the wrong name for the concept I'm using it for here.

Two reasons: firstly, table is a reserved word in SQLite. More importantly, it turns out there's not a direct mapping from tables to types of search result. In particular, for GitHub I ended up having two different "tables" of repositories - one for repos created by me, another for repos that I have starred.

@simonw simonw added the enhancement New feature or request label Sep 6, 2020
@simonw
Copy link
Collaborator Author

simonw commented Sep 6, 2020

At some point I may even want to support search types which are indexed from (and inflated from) more than one database file. I'm going to ignore that for the moment though.

@simonw
Copy link
Collaborator Author

simonw commented Sep 9, 2020

Alternative names:

  • type
  • record_type
  • doctype

I think type is right. It matches what Elasticsearch used to call their equivalent of this (before they removed the feature!). https://www.elastic.co/guide/en/elasticsearch/reference/current/removal-of-types.html

@simonw simonw changed the title "table" is the wrong name for the concept Rename "table" to "type" Sep 9, 2020
simonw added a commit that referenced this issue Sep 9, 2020
simonw added a commit that referenced this issue Sep 9, 2020
@simonw simonw closed this as completed Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant