Fix CMake build for missing libraries #4801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@edewata The test still fails but in a following step. I'll do some investigation for this or following PR |
edewata
approved these changes
Jul 11, 2024
base/CMakeLists.txt
Outdated
| # use system JARs | ||
|
|
||
| else() |
There was a problem hiding this comment.
The else() should be above the use system JARs comment.
The test for jackson and resteasy library was failing because the variable is undefined when the libraries are not provided with the package. Since CMake test works with variables considering false when the variable is undefined the all the is statements have been modified to check if the variable is defined. https://cmake.org/cmake/help/latest/command/if.html#variable
|
@edewata Thanks! I am merging this and look at the remaining problems in a following PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for jackson and resteasy library was failing because the variable is undefined when the libraries are not provided with the package.
Since CMake test works with variables considering false when the variable is undefined the all the is statements have been modified to check if the variable is defined.
https://cmake.org/cmake/help/latest/command/if.html#variable
Error example available here: https://github.com/dogtagpki/pki/pull/4800/checks?check_run_id=27329408722