Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move from sudo to runuser #494

Merged
merged 1 commit into from
Aug 5, 2020

Conversation

SilleBille
Copy link
Member

This patch migrates usage of sudo to runuser. In containers,
sudo is not installed by default. Whereas, runuser is part of
'util-linux' pacakge, whcih is installed by default

Fixes: https://pagure.io/dogtagpki/issue/3171

Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>

This patch migrates usage of sudo to runuser. In containers
sudo is not installed by default. Whereas, `runuser` is part of
'util-linux' pacakge, whcih is installed by default

Fixes: https://pagure.io/dogtagpki/issue/3171

Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
@SilleBille SilleBille self-assigned this Jul 23, 2020
@SilleBille SilleBille added Enhancement New features and enhancements related to the product needs-review labels Jul 23, 2020
@SilleBille
Copy link
Member Author

Should we wait till we branch 10.9? Thoughts @edewata @cipherboy ?

@cipherboy
Copy link
Member

We should probably wait.

@cipherboy
Copy link
Member

I would recommend adding sudo into Requires: section though.

@edewata
Copy link
Contributor

edewata commented Jul 23, 2020

I don't know enough about runuser. It looks fine to me, but if they can wait we're going to branch PKI 10.9 in about a week.

@SilleBille
Copy link
Member Author

I would recommend adding sudo into Requires: section though.

Why depend on a package rather than using a built-in tool that provides the same functionality? My $0.02 :-)

@cipherboy
Copy link
Member

A separate PR, to reflect the current reality. Then no system ends up without sudo but with PKI packages. Also, sudo could be considered built in (it is present by default in Fedora) until something goes and removes it (minimization project). And runuser isn't necessarily any more built in, it just happens to be present in more scenarios. :)

@SilleBille
Copy link
Member Author

The runuser is part of util-linux package, which is a low-level system utility required to boot a system. sudo is an optional package in containers (and may be removed in future as Fedora minimization effort).

Copy link
Contributor

@edewata edewata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SilleBille
Copy link
Member Author

Thanks for the review and thoughts! Merging this based on the ACK and green light from CI. Hopefully, this doesn't cause a testing holocaust 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New features and enhancements related to the product needs-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants