-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move from sudo to runuser #494
Move from sudo to runuser #494
Conversation
This patch migrates usage of sudo to runuser. In containers sudo is not installed by default. Whereas, `runuser` is part of 'util-linux' pacakge, whcih is installed by default Fixes: https://pagure.io/dogtagpki/issue/3171 Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>
Should we wait till we branch 10.9? Thoughts @edewata @cipherboy ? |
We should probably wait. |
I would recommend adding |
I don't know enough about |
Why depend on a package rather than using a built-in tool that provides the same functionality? My $0.02 :-) |
A separate PR, to reflect the current reality. Then no system ends up without |
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for the review and thoughts! Merging this based on the ACK and green light from CI. Hopefully, this doesn't cause a testing holocaust 😉 |
This patch migrates usage of sudo to runuser. In containers,
sudo is not installed by default. Whereas,
runuser
is part of'util-linux' pacakge, whcih is installed by default
Fixes: https://pagure.io/dogtagpki/issue/3171
Signed-off-by: Dinesh Prasanth M K <dmoluguw@redhat.com>