Fix Kubeip not replacing IPs if node's access config name != external-nat #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The steps that Kubeip follows to replace an ephemeral IP with an external IP on a given node, among others, are: * Delete the node's access config called 'external-nat'. * Create a new access config for the node with a free external IP. If the node's access config has a name different than 'external-nat', it doesn't get deleted and, when attempting to add another access config with the external IP, the GCloud API returns a 400: "googleapi: Error 400: At most one access config currently supported. badRequest" To work this around, instead of assuming that the access config will be called 'external-nat', actively retrieve the access config name and use this retrieved name to issue the DeleteAccessConfig request.
avivl
approved these changes
Sep 8, 2019
avivl
approved these changes
Sep 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The steps that Kubeip follows to replace an ephemeral IP with an
external IP on a given node, among others, are:
If the node's access config has a name different than 'external-nat', it
doesn't get deleted and, when attempting to add another access config with
the external IP, the GCloud API returns a 400:
"googleapi: Error 400: At most one access config currently supported.
badRequest"
To work this around, instead of assuming that the access config will be
called 'external-nat', actively retrieve the access config name and use
this retrieved name to issue the DeleteAccessConfig request.