Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experimental speed flag #283

Merged
merged 5 commits into from Jun 11, 2019

Conversation

@matt-gadd
Copy link
Contributor

commented Jun 11, 2019

Type: feature

The following has been addressed in the PR:

  • All code has been formatted with prettier

Adds an experimental options bag for the .dojorc. Adds a flag called speed, produces a much quicker build in dev mode at the cost of:

  • no typechecking
  • no legacy support
  • no codesplitting
  • no postcss support
  • no cssnano

This flag is automatically disabled when in any other mode other than dev.

In very large projects this can mean significant gains in both cold builds and watch builds during development. An example large project -
without experimental speed flag:

$ time dojo build -m dev
 106.02 real       150.63 user         5.29 sys

with experimental speed flag:

$ time dojo build -m dev
29.01 real        46.77 user         2.26 sys
@codecov

This comment has been minimized.

Copy link

commented Jun 11, 2019

Codecov Report

Merging #283 into master will decrease coverage by 0.7%.
The diff coverage is 5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #283      +/-   ##
==========================================
- Coverage   51.46%   50.76%   -0.71%     
==========================================
  Files          10       10              
  Lines         647      656       +9     
  Branches      169      176       +7     
==========================================
  Hits          333      333              
- Misses        314      323       +9
Impacted Files Coverage Δ
src/dev.config.ts 19.29% <0%> (-0.71%) ⬇️
src/base.config.ts 21.5% <0%> (-1.19%) ⬇️
src/main.ts 88.95% <100%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ef5f80...25dd50d. Read the comment docs.

@matt-gadd matt-gadd merged commit 0185a22 into dojo:master Jun 11, 2019

3 of 5 checks passed

codecov/patch 5% of diff hit (target 51.46%)
Details
codecov/project 50.76% (-0.71%) compared to 8ef5f80
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.