-
Notifications
You must be signed in to change notification settings - Fork 58
Conversation
@@ -36,7 +36,7 @@ export interface DateProperties { | |||
year: number; | |||
} | |||
|
|||
const days = [ null, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 ]; | |||
const days = [ -1, 31, 28, 31, 30, 31, 30, 31, 31, 30, 31, 30, 31 ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should add a comment here overall... because this is an odd array and has no documentation. Would NaN
be appropriate here instead of -1
?
@@ -115,21 +118,22 @@ export default class UrlSearchParams { | |||
* @param key The key to return the first value for | |||
* @return The first string value for the key | |||
*/ | |||
get(key: string): string { | |||
get(key: string): string | undefined { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are two spaces here... I know, being pedantic.
Also for the record, I am currently getting:
When doing a |
@kitsonk if you remove the |
Ah, ok, but as far as cleaning typings, see dojo/grunt-dojo2#4 which has been open for a while, because it isn't the first time it has happened... 😭 |
👍 |
There are some test failure, fixing. |
Unit tests failures fixed. |
Dependant on dojo/shim#2
strictNullChecks
noImplicitThis
Fixes #147