Skip to content
This repository has been archived by the owner on Jul 30, 2018. It is now read-only.

load: use Require interface from dojo-loader for AMDRequire #58

Closed
wants to merge 1 commit into from

Conversation

msssk
Copy link
Contributor

@msssk msssk commented Jul 25, 2015

The load module was providing an incomplete definition of the Require (AMDRequire) interface, and duplicating code from dojo-loader.

This commit updates load.ts to instead use the Require interface defined in dojo-loader/loader.

@msssk
Copy link
Contributor Author

msssk commented Jul 25, 2015

Hmmm... I'm not sure this is quite complete. The generated dojo-core-2.0.0-pre.d.ts (from grunt dist) doesn't know about the dojo-loader package - how do we fix that?

@kitsonk
Copy link
Member

kitsonk commented Jul 25, 2015

I will try to look a bit later, but usually it is because you have exported something that dts-generator needs. See SitePen/dts-generator#21.

@kitsonk
Copy link
Member

kitsonk commented Jul 25, 2015

Hmmm actually it looks like maybe dst-generator doesn't handle export as... Maybe open an issue on dts-generator?

@msssk msssk mentioned this pull request Aug 7, 2015
@kitsonk
Copy link
Member

kitsonk commented Nov 17, 2015

I think with TypeScript 1.6, we just need to update our tsconfig.json to reference the loaders typings now. If possible, it would be create to get this PR updated, otherwise I can just land it by doing the changes off the current master.

@bitpshr
Copy link
Member

bitpshr commented Dec 30, 2015

I reverified this; the resulting typings look correct @kitsonk and @msssk.

@kitsonk kitsonk closed this in 120c2a9 Dec 30, 2015
@dylans dylans added this to the Milestone 2 milestone Jan 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants