Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.14 is causing a Maximum call stack size exceeded issue in deepCopy in request/util module when passing a xml or dom node #336

Closed
ThibaultJanBeyer opened this issue Dec 19, 2018 · 0 comments

Comments

@ThibaultJanBeyer
Copy link

ThibaultJanBeyer commented Dec 19, 2018

Dojo 1.14 is causing a Maximum call stack size exceeded issue in deepCopy in request/util module when passing a xml or dom node.

While that worked in 1.13.

Here is an example:
https://codepen.io/ThibaultJanBeyer/pen/vvyVbg
(note that you’ll have to open the console of your web-browser to see the javascript error message)

Toggle between 1.13. and 1.14. See that the one is fine in 1.13 but not in 1.14

I don’t know if that is expected but it just crashed our app and took me a long time to find. So even if this is expected this issue might help someone.

Workaround: stringify the XML / HTML before passing it in the data object.

jamesshaw1987 added a commit to jamesshaw1987/dojo that referenced this issue Apr 25, 2019
@dylans dylans closed this as completed in 30c81b7 Sep 4, 2019
dylans pushed a commit that referenced this issue Sep 4, 2019
dylans pushed a commit that referenced this issue Sep 4, 2019
dylans pushed a commit that referenced this issue Sep 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant