Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update exit and enter animation to use SupportedClassName interface #181

Merged
merged 2 commits into from Nov 26, 2018

Conversation

@agubler
Copy link
Member

commented Nov 22, 2018

Type: bug

The following has been addressed in the PR:

Description:

Adds the SupportedClassName interface for the exitAnimation and enterAnimation vnode properties. The vdom already deals with undefined and null values, added some tests to demonstrate that.

Resolves #134 (partially)
Supersedes #135

@tomdye
tomdye approved these changes Nov 26, 2018

@agubler agubler merged commit 0a2a6da into dojo:master Nov 26, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 54d27bb...8a5e81f
Details
codecov/project 97.09% (+<.01%) compared to 54d27bb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
licence/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.