Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate existing dojo/core modules #53

Merged
merged 2 commits into from
Aug 13, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 1, 2018

Type: feature

The following has been addressed in the PR:

Description:

There are a lot of historical and outdated modules provided within core that aren't required when working with dojo framework. These modules were originally created based on previous dojo toolkit utils and have mostly become redundant and unmaintained.

There are a couple of exceptions including request and task that could potentially be pulled into dedicated projects with champions to manage bugs and enhancements ensuring that they offer benefit over existing native implementations (such as fetch for request).

However, these modules are not used by dojo framework and shouldn't be needed by consumers. Instead using alternatives such as a fetch polyfill for consumers that need to support IE11.

Removed:

  • @dojo/framework/core/DateObject.ts
  • @dojo/framework/core/IdentityRegistry.ts
  • @dojo/framework/core/List.ts
  • @dojo/framework/core/MatchRegistry.ts
  • @dojo/framework/core/MultiMap.ts
  • @dojo/framework/core/Observable.ts
  • @dojo/framework/core/Scheduler.ts
  • @dojo/framework/core/UrlSearchParams.ts
  • @dojo/framework/core/aspect.ts
  • @dojo/framework/core/async/ExtensiblePromise.ts
  • @dojo/framework/core/async/Task.ts
  • @dojo/framework/core/async/iteration.ts
  • @dojo/framework/core/async/timing.ts
  • @dojo/framework/core/base64.ts
  • @dojo/framework/core/compare.ts
  • @dojo/framework/core/global.ts
  • @dojo/framework/core/has.ts
  • @dojo/framework/core/instrument.ts
  • @dojo/framework/core/interfaces.ts
  • @dojo/framework/core/lang.ts
  • @dojo/framework/core/load.ts
  • @dojo/framework/core/load/util.ts
  • @dojo/framework/core/load/webpack.ts
  • @dojo/framework/core/main.ts
  • @dojo/framework/core/on.ts
  • @dojo/framework/core/queue.ts
  • @dojo/framework/core/request.ts
  • @dojo/framework/core/request/Headers.ts
  • @dojo/framework/core/request/ProviderRegistry.ts
  • @dojo/framework/core/request/Response.ts
  • @dojo/framework/core/request/SubscriptionPool.ts
  • @dojo/framework/core/request/TimeoutError.ts
  • @dojo/framework/core/request/interfaces.d.ts
  • @dojo/framework/core/request/providers/node.ts
  • @dojo/framework/core/request/providers/xhr.ts
  • @dojo/framework/core/stringExtras.ts
  • @dojo/framework/core/text.ts
  • @dojo/framework/core/util.ts (some modules removed)
    • createTimer
    • throttleAfter

Moved:

  • @dojo/framework/core/has.ts -> @dojo/framework/has/presets.ts
  • @dojo/framework/core/interfaces.ts
    • Handle -> @dojo/framework/core/Destroyable.ts
    • EventObject -> @dojo/framework/core/Evented.ts
  • @dojo/framework/core/uuid.ts -> @dojo/framework/core/util.ts (from default to named export)
  • @dojo/framework/core/lang#deepAssign -> @dojo/framework/core/util#deepAssign
  • @dojo/framework/core/lang#mixin -> @dojo/framework/core/util#mixin

Resolves #52

@agubler agubler added enhancement New feature or request next Issue/Pull Request for the next major version labels Aug 1, 2018
@agubler agubler force-pushed the core-cull branch 2 times, most recently from 11827ad to 9ed4141 Compare August 1, 2018 13:31
@agubler agubler changed the base branch from next to master August 10, 2018 22:15
@agubler agubler merged commit 07f327e into dojo:master Aug 13, 2018
@agubler agubler added the breaking change Indicates the issue/pull request would result in a breaking change label Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request next Issue/Pull Request for the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants