Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change diff type for Themed Mixin to auto #685

Merged
merged 1 commit into from Mar 18, 2020
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Mar 12, 2020

Type: bug

The following has been addressed in the PR:

Description:

Use auto over shallow for the diff type of theme, classes and extraClasses in the Themed mixin to prevent unnecessarily invalidating when undefined is explicitly passed to a widget.

Resolves #609

@agubler agubler added needs back-port area: core labels Mar 12, 2020
@codesandbox-ci
Copy link

codesandbox-ci bot commented Mar 12, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2ebe4db:

Sandbox Source
aged-feather-uc7sh Configuration

@codecov
Copy link

codecov bot commented Mar 18, 2020

Codecov Report

Merging #685 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #685      +/-   ##
==========================================
- Coverage   97.77%   97.77%   -0.01%     
==========================================
  Files         117      117              
  Lines        6615     6614       -1     
  Branches     1502     1502              
==========================================
- Hits         6468     6467       -1     
  Misses        147      147              
Impacted Files Coverage Δ
src/core/mixins/Themed.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d03fae...2ebe4db. Read the comment docs.

@agubler agubler merged commit 115de94 into dojo:master Mar 18, 2020
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: core needs back-port
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants