Adds helpful failure messages when a test operation fails. #71
Conversation
|
Sample error message
Errors are a notification + cause; i.e. "Test operation failure at ${ location }. ${ cause }". (see https://github.com/dojo/framework/pull/71/files#diff-a6b7da537e090f6599b6cde4522e420dR59). Sample list of causes here: https://github.com/dojo/framework/pull/71/files#diff-8d68c3bca00aa78c6f8ad7d262a0442bR71 |
src/stores/state/Patch.ts
Outdated
| @@ -51,6 +52,15 @@ function add(pointerTarget: PointerTarget, value: any): any { | |||
| return pointerTarget.object; | |||
| } | |||
|
|
|||
| function assert(pointerTarget: PointerTarget, value: any) { | |||
There was a problem hiding this comment.
Can we keep this as test inline with the operation type?
There was a problem hiding this comment.
I moved it to match the other sections and because the test seemed like a separate responsibility from transversing the paths. Since I moved the comparison stuff for the difference message into its own function there's not a lot of complexity so I guess it's ok to move it back.
|
Do you think we can report the whole path to the failed test? I think at the moment you are just reporting the segment. |
|
resolved comments and added tests to match changes. 👍 |
Resolves #44