Support rendering multiple routes to an Outlet #716
Conversation
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 683bff0:
|
Codecov Report
@@ Coverage Diff @@
## master #716 +/- ##
==========================================
+ Coverage 97.75% 97.77% +0.01%
==========================================
Files 120 121 +1
Lines 6949 7010 +61
Branches 1577 1592 +15
==========================================
+ Hits 6793 6854 +61
Misses 156 156
Continue to review full report at Codecov.
|
docs/en/routing/introduction.md
Outdated
|
|
||
| To take advantage of the code splitting there are 4 rules: | ||
|
|
||
| 1. The routing configuration needs to be the default export in the `src/routes.ts` module. | ||
| 2. The widgets must be the default export of their module. | ||
| 3. The `renderer` property must be defined inline. | ||
| 4. The outlet `id` must be static and defined inline. | ||
| 4. The `id` and `outlet` in the routing config and must be static and defined inline. |
There was a problem hiding this comment.
Not sure if "routing config and" is missing the and's "what" or just an extra "and"
Co-Authored-By: Bradley Maier <brdlmaier49@gmail.com>
docs/en/routing/introduction.md
Outdated
| }); | ||
| ``` | ||
|
|
||
| or using outlets and the `Outlet` widget, check out the [`Outlet` documentation](/learn/routing/outlets) for more information; |
There was a problem hiding this comment.
incomplete thought / start of sentence?
There was a problem hiding this comment.
@dylans I think this is supposed to be a colon for the example below
Co-Authored-By: Dylan Schiemann <dylan@dojotoolkit.org>
|
@dylans I've updated based on your review. |
Type: feature
The following has been addressed in the PR:
prettieras per the readme code style guidelinesDescription:
Changes the concept of an
Outletto support rendering multiple matching "routes" to a single outlet. Now using an outlet gives flexibility to render views for an application's routes in a more natural layout, reduces repetitive uses of anOutletthat duplicate layout and logic.The existing
Outletbehaviour has been moved toRoutethat more accurately describes its behaviour.Resolves #715