Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up across the READMEs #81

Merged
merged 5 commits into from
Sep 4, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Aug 24, 2018

Type: bug

The following has been addressed in the PR:

Description:

Adds prettier for markdown and cleans up references

- [Conditional Module Loading](#conditional-module-loading)
- [Static Features](#static-features)
- [Features](#features)
- [Feature Branching](#feature-branching) - [Included Features](#included-features) - [Adding a Feature Test/Feature Detection](#adding-a-feature-testfeature-detection) - [Conditional Module Loading](#conditional-module-loading) - [Static Features](#static-features)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is pushing this onto one line correct?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope, good spot.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed up @dylans

@agubler
Copy link
Member Author

agubler commented Aug 28, 2018

@dylans do you think you'll be able to review this?

Copy link
Contributor

@JamesLMilner JamesLMilner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@agubler agubler merged commit 0a8ada8 into dojo:master Sep 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants