Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the middleware key as the middleware id in the test renderer #859

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

matt-gadd
Copy link
Contributor

Type: feature

The following has been addressed in the PR:

Description:
This should make it easier to test things that leverage the middleware id, by not using a uuid and instead using the middleware key itself which is unique enough for the widget under test.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 901999d:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Nov 18, 2020

Codecov Report

Merging #859 (901999d) into master (ad846c0) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #859      +/-   ##
==========================================
- Coverage   94.71%   94.71%   -0.01%     
==========================================
  Files         127      127              
  Lines        8085     8084       -1     
  Branches     1884     1884              
==========================================
- Hits         7658     7657       -1     
  Misses        427      427              
Impacted Files Coverage Δ
src/testing/renderer.ts 97.32% <ø> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad846c0...901999d. Read the comment docs.

@matt-gadd matt-gadd merged commit 23c7eda into dojo:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants