Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refines the create template function APIs #866

Merged
merged 2 commits into from
Dec 1, 2020

Conversation

agubler
Copy link
Member

@agubler agubler commented Nov 27, 2020

Type: feature

The following has been addressed in the PR:

Description:

Merges createResourceTemplate, createResourceTemplateWithInit and createMemoryResourceTemplate in a single createResourceTemplate function that supports creating templates with and without init options and defaults to the old "memory template" which is not going to be called the "default template".

Resolves #864

@agubler
Copy link
Member Author

agubler commented Nov 27, 2020

@matt-gadd is this the kind of change you were thinking for the issue? This still requires docs to be updated and might be nice to provide a shim for the removed APIs to make it non breaking with a deprecated warning?

@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 27, 2020

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit e5e7052:

Sandbox Source
dojo/dojo-codesandbox-template Configuration

@codecov
Copy link

codecov bot commented Nov 27, 2020

Codecov Report

Merging #866 (e5e7052) into master (86011f5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #866   +/-   ##
=======================================
  Coverage   94.72%   94.72%           
=======================================
  Files         127      127           
  Lines        8095     8096    +1     
  Branches     1889     1890    +1     
=======================================
+ Hits         7668     7669    +1     
  Misses        427      427           
Impacted Files Coverage Δ
src/core/middleware/resources.ts 98.61% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86011f5...e5e7052. Read the comment docs.

@agubler agubler changed the title WPI: Refines the create template function APIs Refines the create template function APIs Dec 1, 2020
@agubler agubler merged commit 384c639 into dojo:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider merging createResourceTemplate, createResourceTemplateWithInit and createMemoryResource in Resources
2 participants