Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static routing configuration #98

Merged
merged 1 commit into from
Sep 14, 2018
Merged

Conversation

agubler
Copy link
Member

@agubler agubler commented Sep 13, 2018

Type: feature

The following has been addressed in the PR:

Description:

In order to evaluate routing at build time we need to ensure that it is static, these changes remove support for onEnter and onExit functions in the routing configuration.

The same behaviour is supported by using the outlet event from the router instance:

router.on('outlet', ({ outlet, action }) => {
	if (action === 'enter') {
		if (outlet.id === 'my-outlet') {
			// do something, perhaps fetch data or set state
		}
	}
});

@agubler agubler merged commit fe8faa4 into dojo:master Sep 14, 2018
@agubler agubler added enhancement New feature or request breaking change Indicates the issue/pull request would result in a breaking change next Issue/Pull Request for the next major version labels Sep 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Indicates the issue/pull request would result in a breaking change enhancement New feature or request next Issue/Pull Request for the next major version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants