This repository has been archived by the owner on Dec 13, 2019. It is now read-only.
Convert to TS2.0 and support 'paths' and 'baseUrl' properties #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| return glob; | ||
| }); | ||
| if (tsconfig.filesGlob) { |
There was a problem hiding this comment.
required as for TS2.0 configs filesGlob is replaced by include
Current coverage is 31.57% (diff: 100%)@@ master #11 diff @@
==========================================
Files 4 4
Lines 37 38 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 12 12
- Misses 25 26 +1
Partials 0 0
|
| @@ -1,7 +1,7 @@ | |||
| sudo: false | |||
| language: node_js | |||
| node_js: | |||
| - "4.1" | |||
| - "6.1" | |||
There was a problem hiding this comment.
we should just go with "6" as that will always raise it to the latest of Node.js instead of being "stuck" at 6.1.
There was a problem hiding this comment.
Makes sense, I took the example from widgets. I'll do the same with the package template PR
There was a problem hiding this comment.
I was an idiot with widgets! Upon debating it with @novemberborn I realised that it was best to use 6 with Travis. 😞
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converted to TS2.0 and target ES6.
Add support for
paths/baseUrlcompile properties supported from TS2.0 onwards, currently the only way to support these properties is by usingtscwith atsconfig.jsonnot command line arguments (error TS6064: Option 'paths' can only be specified in 'tsconfig.json' file.).To do this each of the
grunt-tstargets has a customisedtsconfig.jsoncreated at runtime based on the projectstsconfig.jsonusing the convention.tsconfig*.jsonreplacing*with a meaningful description i.e..tsconfigDist.json.The changes are backwards compatible so that any existing consumers will continue to leverage the
grunt-tstasks as previously configured and the new task configuration will only be used ifpathsis detected in thecompilerOptionssection of thetsconfig.Consumers of the new tasks will need to add
.tsconfig*.jsonto the projects.gitignorefile.resolves #10