Dojo theme updates #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomdye
approved these changes
Feb 9, 2018
tomdye
requested changes
Feb 14, 2018
dojo/listbox.m.css
Outdated
| @@ -36,5 +37,16 @@ | |||
| } | |||
|
|
|||
| .selectedOption { | |||
| composes: checkIcon; | |||
There was a problem hiding this comment.
I think this can cause issues with duplicated class names and doesn't make it clear where you are composing from. Are you able to change to composes checkIcon from './icons.m.css' please? Also, are you missing icon class here too?
There was a problem hiding this comment.
It can't use the icon class, since only the pseudo-element should be an icon, and the actual element has normal text.
dojo/listbox.m.css
Outdated
| } | ||
|
|
||
| .selectedOption::before { | ||
| font-family: 'dojo2BaseTheme'; |
There was a problem hiding this comment.
The icon font name. Should probably be moved to a variable.
tomdye
approved these changes
Feb 15, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves the following
@dojo/widgetsissues:dojo/widgets#453
dojo/widgets#239
dojo/widgets#446