Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Material theme: add icon support #62

Closed
wants to merge 1 commit into from
Closed

Material theme: add icon support #62

wants to merge 1 commit into from

Conversation

msssk
Copy link

@msssk msssk commented May 25, 2019

Type: feature

The following has been addressed in the PR:

Description:

  • add material-design-icons to dev dependencies
  • update src/material/icon.m.css to load Material Icons font and apply appropriate fonts to icon component CSS classes

Resolves #61

@msssk
Copy link
Author

msssk commented May 25, 2019

If we update the structure of the icon component to insert the icon name as the content of the <i> element then we don't need all of the CSS classes in this theme.

tomdye
tomdye requested changes Nov 18, 2019
View reviewed changes
Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just thought, does this work built with the relative node_modules paths?

@samends samends mentioned this pull request Dec 10, 2019
Closed
@tomdye
Copy link
Member

tomdye commented Dec 10, 2019

@msssk please re-raise this against widgets. Themes has been ported there.

@tomdye tomdye closed this Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomdye tomdye tomdye requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Material theme: Icon
2 participants
@msssk @tomdye