This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Interface updates #681
Merged
Interface updates #681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
reviewed
Sep 14, 2017
src/meta/Base.ts
Outdated
| const node = this.nodeHandler.get(key); | ||
|
|
||
| if (!node && !this._requestedNodeKeys.has(key)) { | ||
| const handle = this.nodeHandler.on(key, () => { | ||
| const handle = this.nodeHandler.on(key as string, () => { |
There was a problem hiding this comment.
Do you think that we should actually convert this to a string, instead of casting the TS type?
`${key}`
There was a problem hiding this comment.
Yeah, better than assuming there is some sort of implicit coercion of numbers downstream.
kitsonk
reviewed
Sep 15, 2017
| @@ -156,7 +155,7 @@ export class WidgetBase<P = WidgetProperties, C extends DNode = DNode> extends E | |||
| /** | |||
| * cached chldren map for instance management | |||
| */ | |||
| private _cachedChildrenMap: Map<RegistryLabel | Promise<WidgetBaseConstructor> | WidgetBaseConstructor, WidgetCacheWrapper[]>; | |||
| private _cachedChildrenMap: Map<string | number | Promise<WidgetBaseConstructor> | WidgetBaseConstructor, WidgetCacheWrapper[]>; | |||
There was a problem hiding this comment.
Why is it not RegistryLabel | number |...?
There was a problem hiding this comment.
It actually should never have been registry label, the map always takes the key from properties and uses that (or the widget constructor). So I think it wasn't correct to support symbols.
kitsonk
approved these changes
Sep 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
This PR updates the
WidgetPropertiesinterface so thatkeycan be a number or a string. A newKeyedWidgetPropertiesinterface was also added that extendsWidgetPropertiesand makeskeyrequired.Resolves #672