This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Correct run.html path #746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agubler
reviewed
Nov 6, 2017
tests/run.html
Outdated
| @@ -3,7 +3,7 @@ | |||
| <head> | |||
| <meta charset="utf-8"> | |||
| <title>Intern suite</title> | |||
| <meta http-equiv="refresh" content="0;url=../node_modules/intern/client.html?config=_build/tests/intern"> | |||
| <meta http-equiv="refresh" content="0;url=../../node_modules/intern/index.html"> | |||
There was a problem hiding this comment.
I guess it depends where you serve from. I ran my http server from the project root and this works correctly.
There was a problem hiding this comment.
it's got to step out of _build/tests to get to the node_modules folder, so yes, double ../.. required.
There was a problem hiding this comment.
Are you running from the _build directory, because I think now you can just run from the tests directory
tomdye
force-pushed
the
browserTestRunner
branch
from
72007ee
to
79baf44
Compare
kitsonk
reviewed
Nov 8, 2017
agubler
approved these changes
Nov 8, 2017
kitsonk
approved these changes
Nov 8, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the incorrect file path in
run.html