This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Remove Evented and Destroyable from WidgetBase
#761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kitsonk
reviewed
Nov 9, 2017
src/vdom.ts
Outdated
| @@ -746,7 +745,7 @@ function updateDom(previous: any, dnode: InternalDNode, projectionOptions: Proje | |||
| if (hasRenderChanged(previousRendered, rendered)) { | |||
| updateChildren(parentNode, previousRendered, dnode.rendered, instance, projectionOptions); | |||
| projectionOptions.afterRenderCallbacks.push(() => { | |||
| parentInstance.emit({ type: 'widget-updated' }); | |||
| parentInstance.nodeHandler.addRoot(); | |||
|
@kitsonk added back attachHandle and covered the code paths |
kitsonk
approved these changes
Nov 10, 2017
agubler
force-pushed
the
remove-evented
branch
from
18ee570
to
951b965
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: feature
The following has been addressed in the PR:
Description:
Removes
EventedandDestroyablefromWidgetBase,WidgetBasehas been updated to accept an optionalinvalidatemethod in theconstructorthat will be called to propagate invalidation up the widget tree.Performance Comparison against master:
Memory Usage against master:
Related to: #760