This repository has been archived by the owner on Jul 30, 2018. It is now read-only.
Invalidator Fixes: Inject invalidator via setter and reset renderState in scheduleRender #765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ildren for a top level projector
agubler
commented
Nov 10, 2017
| this._parentInvalidator = invalidator; | ||
| } | ||
| else { | ||
| console.warn('Unable to update parent invalidator after it has been set'); |
matt-gadd
approved these changes
Nov 10, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type: bug
The following has been addressed in the PR:
Description:
Having an optional constructor argument for the parent invalidate function is unintuitive and horrible for end users needing to know that they have to pass the arguments on when anything is done in a widget constructor. Moves the injection of the parent invalidate function to a public setter that can only be set once.
The
WidgetBaserender state needs to be reset after running__setProperties__()and__setChildren__()inProjector#scheduleRender()Related to #745