Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds circular loader #1706

Merged
merged 13 commits into from
Mar 30, 2021
Merged

Adds circular loader #1706

merged 13 commits into from
Mar 30, 2021

Conversation

samends
Copy link
Contributor

@samends samends commented Mar 24, 2021

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit tests are included in the PR
  • For new widgets, an entry has been added to the .dojorc
  • For new widgets, theme.variant() is added to the root domnode
  • Any widget variant uses theme.compose like this
  • WidgetProperties are exported

Description:
Adds circular loader to LoadingIndicator widget

Resolves #1584

@vercel
Copy link

vercel bot commented Mar 24, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

widget-test-docs – ./

🔍 Inspect: https://vercel.com/dojo/widget-test-docs/EgWAHYJKsAYTwJC3Kh7osohJsdUV
✅ Preview: https://widget-test-docs-git-fork-samends-circular-loader-dojo1.vercel.app

dojo.widgets – ./

🔍 Inspect: https://vercel.com/dojo/dojo.widgets/3qgXf2ui4nAkmtBWUHukpa5ndu4v
✅ Preview: https://dojowidgets-git-fork-samends-circular-loader-dojo1.vercel.app

@codecov
Copy link

codecov bot commented Mar 24, 2021

Codecov Report

Merging #1706 (59026ab) into master (8bade73) will decrease coverage by 0.01%.
The diff coverage is 81.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1706      +/-   ##
==========================================
- Coverage   90.05%   90.03%   -0.02%     
==========================================
  Files          94       94              
  Lines        5050     5060      +10     
  Branches     1373     1379       +6     
==========================================
+ Hits         4548     4556       +8     
- Misses        249      251       +2     
  Partials      253      253              
Impacted Files Coverage Δ
src/loading-indicator/index.tsx 88.46% <81.25%> (-11.54%) ⬇️
src/text-input/index.tsx 92.68% <0.00%> (-0.24%) ⬇️
src/date-input/index.tsx 91.07% <0.00%> (ø)
src/time-picker/index.tsx 81.81% <0.00%> (ø)
src/password-input/index.tsx 78.57% <0.00%> (ø)
src/chip-typeahead/index.tsx 89.71% <0.00%> (+0.09%) ⬆️
src/select/index.tsx 86.95% <0.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8bade73...59026ab. Read the comment docs.

package.json Show resolved Hide resolved
src/examples/src/widgets/loading-indicator/Circular.tsx Outdated Show resolved Hide resolved
src/loading-indicator/index.tsx Outdated Show resolved Hide resolved
src/loading-indicator/index.tsx Outdated Show resolved Hide resolved
src/loading-indicator/index.tsx Outdated Show resolved Hide resolved
src/loading-indicator/index.tsx Outdated Show resolved Hide resolved
src/theme/dojo/loading-indicator.m.css Show resolved Hide resolved
src/theme/material/loading-indicator.m.css Show resolved Hide resolved
@tomdye
Copy link
Member

tomdye commented Mar 29, 2021

@samends Looks like you've addressed Ant's concerns but I believe it would benefit from having the different sizes examples added to the circular indicator example please.

Copy link
Member

@tomdye tomdye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the extra examples 👍

@samends samends merged commit cb2dd53 into dojo:master Mar 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update animations for LoadingIndicator widget
3 participants