-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds circular loader #1706
Adds circular loader #1706
Conversation
This pull request is being automatically deployed with Vercel (learn more). widget-test-docs – ./🔍 Inspect: https://vercel.com/dojo/widget-test-docs/EgWAHYJKsAYTwJC3Kh7osohJsdUV dojo.widgets – ./🔍 Inspect: https://vercel.com/dojo/dojo.widgets/3qgXf2ui4nAkmtBWUHukpa5ndu4v |
Codecov Report
@@ Coverage Diff @@
## master #1706 +/- ##
==========================================
- Coverage 90.05% 90.03% -0.02%
==========================================
Files 94 94
Lines 5050 5060 +10
Branches 1373 1379 +6
==========================================
+ Hits 4548 4556 +8
- Misses 249 251 +2
Partials 253 253
Continue to review full report at Codecov.
|
@samends Looks like you've addressed Ant's concerns but I believe it would benefit from having the different sizes examples added to the circular indicator example please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the extra examples 👍
Type: feature
The following has been addressed in the PR:
.dojorc
theme.variant()
is added to the root domnodetheme.compose
like thisDescription:
Adds circular loader to
LoadingIndicator
widgetResolves #1584