Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Slider functional tests #178

Closed
wants to merge 4 commits into from
Closed

Add Slider functional tests #178

wants to merge 4 commits into from

Conversation

lzhoucs
Copy link
Contributor

@lzhoucs lzhoucs commented May 17, 2017

Type: functional tests

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Resolves #158

@lzhoucs
Copy link
Contributor Author

lzhoucs commented May 17, 2017

all tests are failing in edge. I saw the same issue locally and I thought it was a browserstack issue.
But it seems it has to do with my tests. Will look into it asap.

@codecov
Copy link

codecov bot commented May 17, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@739d258). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #178   +/-   ##
=========================================
  Coverage          ?   99.24%           
=========================================
  Files             ?       18           
  Lines             ?      929           
  Branches          ?      279           
=========================================
  Hits              ?      922           
  Misses            ?        1           
  Partials          ?        6

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 739d258...8d9aeda. Read the comment docs.

@dylans dylans added this to the 2017.05 milestone May 19, 2017
.findByCssSelector(`.${css.fill}`)
.getAttribute('style')
.then((style: string) => {
const absWidthRegex = /width:\s*(\d+)\.?\d*%/;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can this not be done via a property or similar? regex seems odd.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. I tried the property approach before coming up with this but it didn't work. I used .getProperty('style') but what got returned is an array of property names(['width']) in chrome, instead of an object with which I can then use style.width. If you point me to an example on how this can be done with property, I'd love to make the change.

@lzhoucs lzhoucs self-assigned this Jun 2, 2017
@lzhoucs
Copy link
Contributor Author

lzhoucs commented Jun 2, 2017

The tests were working originally but started failing after recent rebase. Needs to look into it.

@eheasley eheasley modified the milestones: 2017.05, 2017.06 Jun 6, 2017
@dylans dylans modified the milestones: 2017.06, 2017.07 Jul 4, 2017
@dylans dylans modified the milestones: 2017.07, 2017.08 Aug 4, 2017
@kitsonk kitsonk modified the milestones: 2017.08, 2017.09 Sep 4, 2017
@eheasley eheasley modified the milestones: 2017.09, 2017.10 Oct 6, 2017
@pottedmeat pottedmeat mentioned this pull request Oct 20, 2017
3 tasks
@pottedmeat
Copy link
Contributor

Moved to #322

@pottedmeat pottedmeat closed this Oct 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants