Add Slider functional tests
#178
Conversation
|
all tests are failing in edge. I saw the same issue locally and I thought it was a browserstack issue. |
Codecov Report
@@ Coverage Diff @@
## master #178 +/- ##
=========================================
Coverage ? 99.24%
=========================================
Files ? 18
Lines ? 929
Branches ? 279
=========================================
Hits ? 922
Misses ? 1
Partials ? 6Continue to review full report at Codecov.
|
| .findByCssSelector(`.${css.fill}`) | ||
| .getAttribute('style') | ||
| .then((style: string) => { | ||
| const absWidthRegex = /width:\s*(\d+)\.?\d*%/; |
There was a problem hiding this comment.
can this not be done via a property or similar? regex seems odd.
There was a problem hiding this comment.
I agree. I tried the property approach before coming up with this but it didn't work. I used .getProperty('style') but what got returned is an array of property names(['width']) in chrome, instead of an object with which I can then use style.width. If you point me to an example on how this can be done with property, I'd love to make the change.
|
The tests were working originally but started failing after recent rebase. Needs to look into it. |
|
Moved to #322 |
Type: functional tests
The following has been addressed in the PR:
Resolves #158