Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming css modules #85

Merged
merged 4 commits into from
Mar 24, 2017
Merged

Renaming css modules #85

merged 4 commits into from
Mar 24, 2017

Conversation

rorticus
Copy link
Contributor

@rorticus rorticus commented Mar 23, 2017

Type: feature

The following has been addressed in the PR:

  • There is a related issue
  • All code matches the style guide
  • Unit or Functional tests are included in the PR

Description:

Renaming CSS files to .m.css for css modules.

Note that this can't be merged until dojo/grunt-dojo2#124 is :)

@rorticus
Copy link
Contributor Author

(note that the CI failure is typedoc)

Copy link
Member

@bitpshr bitpshr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As long as each example page still works and the CI passes once the grunt-dojo2 updates land, this looks good.

@codecov
Copy link

codecov bot commented Mar 23, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@bd7924c). Click here to learn what that means.
The diff coverage is 100%.

@@           Coverage Diff           @@
##             master    #85   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?     13           
  Lines             ?    573           
  Branches          ?    168           
=======================================
  Hits              ?    573           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/combobox/ResultItem.ts 100% <100%> (ø)
src/dialog/Dialog.ts 100% <100%> (ø)
src/slider/Slider.ts 100% <100%> (ø)
src/slidepane/SlidePane.ts 100% <100%> (ø)
src/checkbox/Checkbox.ts 100% <100%> (ø)
src/textinput/TextInput.ts 100% <100%> (ø)
src/radio/Radio.ts 100% <100%> (ø)
src/combobox/ComboBox.ts 100% <100%> (ø)
src/textarea/Textarea.ts 100% <100%> (ø)
src/combobox/ResultMenu.ts 100% <100%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd7924c...2924a2d. Read the comment docs.

@tomdye
Copy link
Member

tomdye commented Mar 24, 2017

Can you check that the widget.css file still loads the widget css correctly after this change. We need to make sure it's still copied over correctly as this is likely the only remaining special case.

@rorticus
Copy link
Contributor Author

@tomdye , the widgets.css is OK because its being copied over manually by the Gruntfile in here. 👍

@rorticus rorticus merged commit b381d86 into dojo:master Mar 24, 2017
@dylans dylans mentioned this pull request Mar 20, 2017
5 tasks
@dylans dylans added this to the 2017.03 milestone Mar 25, 2017
This was referenced Mar 14, 2017
@tomdye tomdye mentioned this pull request Jan 30, 2020
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants