Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix - Show if an Input Field is Required #176

Merged

Conversation

LuanEdCosta
Copy link
Member

  • Please check if the PR fulfills these requirements
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
    Fix

  • What is the current behavior? (You can also link to an open issue here)
    The user cannot know which fields are required and which are not.

  • What is the new behavior (if this is a feature change)?
    Added the required prop in some TextFields and in some labels to help the user.

  • Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
    No

  • Is there any issue related to this PR in other repository? (such as dojot/dojot)
    GUI - NX - Empty template name dojot#2544

@LuanEdCosta LuanEdCosta requested a review from a team as a code owner June 9, 2022 18:38
@LuanEdCosta
Copy link
Member Author

@luisfelipefurlan @LeonamMoura
Even though the issue pointed the problem only for the template creation page, I added the required prop for TextFields of other pages.

I also want to ask what do you think about adding a * on the attr table header?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants