Улучшения формы в статье Мгновенная валидация форм #5314
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kozlovtseva
requested review from
skorobaeus,
solarrust,
HellSquirrel and
TatianaFokina
as code owners
github-actions
bot
added
статья
skorobaeus
approved these changes
May 6, 2024
HellSquirrel
reviewed
May 9, 2024
| @@ -298,13 +298,19 @@ | |||
| event.preventDefault() | |||
| if (hasInvalidInput()) { | |||
| formError() | |||
| inputList.forEach((inputElement) => { | |||
There was a problem hiding this comment.
тут можно немного сократить
inputList.forEach(checkInputValidity)
HellSquirrel
reviewed
May 9, 2024
There was a problem hiding this comment.
Спасибо! Текущая реализация намного лучше :)
Но у нее все еще есть проблема
Если заполнить все поля правильно, но не убрать фокус с последнего поля в котором была ошибка, кнопка сабмита недоступна, см пример ниже
Самый простой способ решить эту проблему - не дизейблить кнопку сабмита
Способ посложнее - следить за изменением состояния формы при каждом обновлении поля, когда форма валидная делать кнопку отправки доступной, но ошибку показывать только на blur
Превью контента из f53ac2d опубликовано. |
|
@HellSquirrel привет) большое спасибо за ревью! пушнула правочки |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Описание
Улучшения формы в статье Мгновенная валидация форм:
номер ишью - #5273
Чек-лист
/css/color/,/tools/json/,/tools/gulp/#kak-ponyat)images/example.png,demos/example/,../demos/example/)