Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dokku_acl_app and dokku_acl_service ansible libraries #155

Merged
merged 2 commits into from
Dec 19, 2022

Conversation

ltalirz
Copy link
Member

@ltalirz ltalirz commented Dec 19, 2022

This PR provides a couple of minor fixes:

  1. the dokku commands that list ACL information return the data on stderr, however the plugin was trying to read it from stdout. Added a redirect_stderr option on subprocess_check_output (which defaults to False, to avoid breaking usage anywhere else), and then modified dokku_acl_app and dokku_acl_service to set that to True
  2. The dokku_acl_service module wasn't using the right dokku acl:... commands to list/add/remove

This change is pretty small, I've tested this locally to confirm it works. Let me know if anything else is needed!

@ltalirz ltalirz merged commit e7eaeee into master Dec 19, 2022
@ltalirz ltalirz deleted the dvessey-fes-fix_acl branch December 19, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants