Use exported environment vars during pack build #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josegonzalez
requested changes
Nov 27, 2021
emdienn
commented
Nov 29, 2021
Config was exported, but the result never used.
Docker accepts its flags as --env=FOO but pack requires --env FOO, which is why ENV_ARGS_VALUES is iterated into ENV_ARGS, then pack run through eval
Also add a test for env vars during build time for pack-built applications.
josegonzalez
force-pushed
the
bugfix/env-at-build-time
branch
from
c79547d
to
6f55b89
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
# History ## 0.26.7 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.26.7/bootstrap.sh sudo DOKKU_TAG=v0.26.7 bash bootstrap.sh ``` ### Bug Fixes - #5003: @josegonzalez Respect pre-existing .env files when preparing the herokuish buildenv - #4950: @emdienn Use exported environment vars during pack build - #4999: @elhu Purge cache for all apps when calling buildpacks:set-property with --global flag - #4988: @fomojola Conditionally restart NGINX - #4922: @josegonzalez Gitignore more built plugin triggers in apps plugin ### New Features - #4964: @josegonzalez Add log message when running state is false - #4970: @josegonzalez Log the string error and not bytes when there is an issue updating the cron schedule - #4924: @josegonzalez Update devcontainer to include aliased go packages - #4920: @josegonzalez Ensure related go source and vscode plugins are installed in devcontainer ### Documentation - #4949: @IlyaSemenov docs: update herokuish upgrade instructions - #4992: @anthonyshew Typo for deploying using image SHA - #4976: @josegonzalez Update link in header to dokku pro - #4972: @Dam-Buty Clarify cron:report command - #4943: @Stormheg Fix typo in registry management documentation - #4935: @josegonzalez Reword note about env vars in nginx config templates ### Other - #4995: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 203 to 205 in /tests/apps/php - #4978: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 201 to 203 in /tests/apps/php - #4936: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 200 to 201 in /tests/apps/php - #4937: @dependabot[bot] chore(deps): bump socket.io from 4.3.2 to 4.4.0 in /tests/apps/.websocket.disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey all, in using the builder-pack packer, I came across the scenario where my apps' config variables weren't being drawn into the build process like the documentation intimated it would/should.
Digging into it, I discovered that in the builder-pack build script, the
config_exportis called and stored in a file, but then that file is never touched again.Figuring this was an oversight, I made a fix and would like to share it back into the codebase.
Why did I use
sedon the "pretty" format instead of just use the "envfile" format?Great question.
The tl:dr; is that the "envfile" format provided by
configis actually incorrect: it surrounds the value of the variable in single quotes, ie.causing the value to include the quotes, because environment variables should* be specified as
After digging through the
configsubcommand codebase, I determined that this is being done by a dependency package (namelygithub.com/joho/godotenv) - rather than start wrangling the format (which might have implications elsewhere) I opted for a more localised solution.*I couldn't find an authoritative source for the exact semantics of a dotenv file, but every other platform and system I have ever seen or used does not wrap the value in quotes. I'm happy to be wrong, but
packrequires no-quote syntax regardless.Anyway. Love dokku, hope you find this PR helpful.