Conditionally restart NGINX #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before restarting nginx, check if the current app is using a proxy and if the selected proxy is in fact NGINX. Only then should we bother invoking the nginx reload. Fixes dokku#4987
josegonzalez
requested changes
Dec 31, 2021
|
Thanks for the pull request, it's much appreciated! |
|
Had to install shfmt: should be good to go now. |
github-actions bot
pushed a commit
that referenced
this pull request
Jan 18, 2022
# History ## 0.26.7 Install/update via the bootstrap script: ```shell wget https://raw.githubusercontent.com/dokku/dokku/v0.26.7/bootstrap.sh sudo DOKKU_TAG=v0.26.7 bash bootstrap.sh ``` ### Bug Fixes - #5003: @josegonzalez Respect pre-existing .env files when preparing the herokuish buildenv - #4950: @emdienn Use exported environment vars during pack build - #4999: @elhu Purge cache for all apps when calling buildpacks:set-property with --global flag - #4988: @fomojola Conditionally restart NGINX - #4922: @josegonzalez Gitignore more built plugin triggers in apps plugin ### New Features - #4964: @josegonzalez Add log message when running state is false - #4970: @josegonzalez Log the string error and not bytes when there is an issue updating the cron schedule - #4924: @josegonzalez Update devcontainer to include aliased go packages - #4920: @josegonzalez Ensure related go source and vscode plugins are installed in devcontainer ### Documentation - #4949: @IlyaSemenov docs: update herokuish upgrade instructions - #4992: @anthonyshew Typo for deploying using image SHA - #4976: @josegonzalez Update link in header to dokku pro - #4972: @Dam-Buty Clarify cron:report command - #4943: @Stormheg Fix typo in registry management documentation - #4935: @josegonzalez Reword note about env vars in nginx config templates ### Other - #4995: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 203 to 205 in /tests/apps/php - #4978: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 201 to 203 in /tests/apps/php - #4936: @dependabot[bot] chore(deps-dev): bump heroku/heroku-buildpack-php from 200 to 201 in /tests/apps/php - #4937: @dependabot[bot] chore(deps): bump socket.io from 4.3.2 to 4.4.0 in /tests/apps/.websocket.disabled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before restarting nginx, check if the current app is using a proxy and if the selected proxy is in fact NGINX. Only then should we bother invoking the nginx reload.
Fixes #4987