PEP 386 Version identification #179
Conversation
newsletter/__init__.py
Outdated
There was a problem hiding this comment.
This breaks the installer if Django is not yet installed (so for a fresh install of all your requirements for instance).
Since setup.py is used to install, and it imports newsletter, it will crash on the django import.
I have fixed this for django-choices the following way: bigjason/django-choices@b95612e
There was a problem hiding this comment.
This seems also the approach taken by the debug toolbar: https://github.com/django-debug-toolbar/django-debug-toolbar/blob/master/debug_toolbar/__init__.py
There was a problem hiding this comment.
This is easily unit testable with tox as well where you don't pin a certain Django version in your tox requirements, and let newsletter pull in Django itself.
There was a problem hiding this comment.
Thank you for the detected error
|
What exactly is the advantage of setting the version number in this fashion? |
|
No reply to my enquiry, I'm closing this one. Should you be able to tell me why this is useful I might reconsider. |
No description provided.