Add possibility to add Attachments to a Message #334
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # newsletter/admin.py # newsletter/models.py
|
@dokterbob @claudep any suggestions how this could be improved? Or would this be acceptable for merging? |
|
@dokterbob could you look into this please? |
|
Sorry for the late reply. I like the idea, especially considering that it's an optional feature. Code looks very nice. Coverage increased. Very well done! Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
Attachmentmodel which has aForeignKeytoMessage. With this it is (optionally) possible to upload one or more files for aMessage. When the message is send out the files are attached as normal e-mail attachments. The "read online" pages include a download link to these files.A new migration has been created
0006_attachment.pyand thegraph_modelsfor the documentation have been updated.Basic tests for the new functionality are included.
This is a replacement for #145.
Screenshot - Django Admin:
Screenshot - Thunderbird:
Screenshot - Online View:
