New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] Add Arch Linux's PKGBUILD and instructions for installation #13

Merged

dokutan merged 1 commit into dokutan:master from unknown repository

Feb 10, 2021

ghost commented Feb 10, 2021

Maybe this mess needs a review before the merge


          [build] Add Arch Linux's PKGBUILD and instructions for installation

f673d07

dokutan mentioned this pull request

PKGBUILD for Arch Linux #14

Closed

Owner

dokutan commented Feb 10, 2021 •

edited

Loading

This looks good and i can confirm that it works. ~~However before merging this i would like to hear your opinion about #14.~~

As for review, these are things that i would consider changing about this PKGBUILD:

g++ or clang++ should be added to makedepends
~~SKIP the checksum as this is a *-git package~~ it is obviously not, i am dumb
Add the resulting files to .gitignore and make clean

dokutan merged commit c4d110d into dokutan:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet