PSR-2 Chages for the plugins #2757
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thos broke during refactoring
This method did absolutely nothing and just returned the plugin name.
Boolean Methods with a negative name are a bit confusing. Getting false for an enabled plugin? Better check for Enabled status.
There is no need to have them in a global variable.
For compatibility reasons with basically all existing plugins, the methods have not been renamed. Instead the appropriate check is ignored.
For compatibility reasons, the methods have not been renamed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are the first commits I did in #2426 before I got derailed, rebased on top of the current psr-2 branch. Took a bit of manual merging, so it would be good to have another pair of eyes, before this is merged into the psr-2 branch as I may have missed something. But it should be a good base for finishing the psr-2 stuff...