Impossible to multiple patches of a key in a same paragraph

[Suniron]

Hey there!

I can't do multiple patches of the same key in one sentence.

For example, in the following text, only the first key will be patched:

The company {{company_name}}, is {{company_name}}

I'm using the code above to patch my docx files:

import {
  PatchType,
  TextRun,
  patchDocument,
} from 'docx'

const patchedDocxTemplate = await patchDocument(baseDocxTemplate, {
   patches: {
    company_name: {
      children: [new TextRun('MY_COMPANY')],
      type: PatchType.PARAGRAPH,
    },
  }
})

[Suniron]

I'm using this fix but I'm not really proud of it 🥲

      const patchTheDocument = async (data: Buffer) => await patchDocument(data, {
        patches: {
          company_name: {
            children: [new TextRun('MY_COMPANY')],
            type: PatchType.PARAGRAPH,
          },
        },
      })

      // Patch the document a first time:
      let patchedDocxTemplate = await patchTheDocument(baseDocxTemplate)
      // Patch the document 10 times to avoid the case where multiple same keys are in the template (not patched), see https://github.com/dolanmiu/docx/issues/2267
      for (let i = 0; i < 10; i++) {
        patchedDocxTemplate = await patchTheDocument(Buffer.from(patchedDocxTemplate))
      }

[mateobv07]

I'm using this fix but I'm not really proud of it 🥲

      const patchTheDocument = async (data: Buffer) => await patchDocument(data, {
        patches: {
          company_name: {
            children: [new TextRun('MY_COMPANY')],
            type: PatchType.PARAGRAPH,
          },
        },
      })

      // Patch the document a first time:
      let patchedDocxTemplate = await patchTheDocument(baseDocxTemplate)
      // Patch the document 10 times to avoid the case where multiple same keys are in the template (not patched), see https://github.com/dolanmiu/docx/issues/2267
      for (let i = 0; i < 10; i++) {
        patchedDocxTemplate = await patchTheDocument(Buffer.from(patchedDocxTemplate))
      }

Im still having the same issue when the same word to be patched is multiple times in the same paragraph, using your fix worked but is there a better solution now?

[carlgleisner]

I'm also running into this 🤔

[Suniron]

I don't really understand why my issue was closed.. 😞

[carlgleisner]

Ok @Suniron I'm going to attempt to debug this issue and provide a solution – if possible. Don't know when I'll be able to find the time to familiarise myself with the codebase but, yeah. It's the "open source thing" to do in this situation. Very happy to contribute! If I'm able to solve it.

To state the obvious: I guess it's a logical issue where subsequent occurrences of a {{patch}} within the same paragraph aren't processed.

If we put our minds together at some point, we really should be able to get to the bottom of this.

[mateobv07]

Thanks @carlgleisner If you need any help im down, I also really want this fixed :)

[mateobv07]

I started looking into this, I am pretty sure it has already been fixed lol. I think this is the problem #2605

It isnt released in the latest npm version. When I cloned the project and started running some tests it was actually working and replacing all patches in the same paragraph.

[carlgleisner]

I think this is the problem #2605

This makes a lot of sense 🙂

Amazing library – would have loved to contribute! I guess new opportunities will present themselves.