Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: add line numbers to section #262

Merged
merged 3 commits into from
Jun 5, 2019
Merged

Feature: add line numbers to section #262

merged 3 commits into from
Jun 5, 2019

Conversation

aravindballa
Copy link
Contributor

This PR has the changes required for adding line-numbers to the Section Options.

http://officeopenxml.com/WPsectionLineNumbering.php

@dolanmiu
Copy link
Owner

dolanmiu commented Feb 6, 2019

Could you add an example on how to use this feature?

@aravindballa
Copy link
Contributor Author

I just added an example in ./demo/demo40.ts. Here is the output of it.

image

@knowtheory
Copy link

fwiw, i could totally use this on a project i'm working on right now :)

@dolanmiu
Copy link
Owner

dolanmiu commented Jun 2, 2019

If the author doesn't fix the build, i will fix it, make sure it passes and then merge

@codecov-io
Copy link

Codecov Report

Merging #262 into master will increase coverage by 1.4%.
The diff coverage is 73.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #262     +/-   ##
=========================================
+ Coverage   89.56%   90.97%   +1.4%     
=========================================
  Files         242      250      +8     
  Lines        2846     2869     +23     
  Branches      156       69     -87     
=========================================
+ Hits         2549     2610     +61     
+ Misses        257      241     -16     
+ Partials       40       18     -22
Impacted Files Coverage Δ
...ument/body/section-properties/line-number/index.ts 100% <100%> (ø)
src/file/document/body/section-properties/index.ts 100% <100%> (ø) ⬆️
...ment/body/section-properties/section-properties.ts 96.22% <66.66%> (-0.39%) ⬇️
...body/section-properties/line-number/line-number.ts 70% <70%> (ø)
src/file/table/table-properties/table-width.ts 85.71% <0%> (-14.29%) ⬇️
src/file/table/table-cell/table-cell-properties.ts 90.9% <0%> (-9.1%) ⬇️
...rc/file/table/table-properties/table-properties.ts 91.66% <0%> (-8.34%) ⬇️
src/file/paragraph/links/hyperlink.ts 92.3% <0%> (-7.7%) ⬇️
...c/file/table/table-properties/table-cell-margin.ts 78.26% <0%> (-1.74%) ⬇️
src/file/table/table-cell/table-cell.ts 71.42% <0%> (-1.65%) ⬇️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 83a7f46...2f68712. Read the comment docs.

@dolanmiu dolanmiu merged commit a5afce4 into dolanmiu:master Jun 5, 2019
@dolanmiu
Copy link
Owner

dolanmiu commented Jun 5, 2019

Thanks! merged

will release a new rc soon

@dolanmiu
Copy link
Owner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants